Move docker build and push to its own action #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
force-pushed
the
move-docker-push-to-a-reusable-action
branch
2 times, most recently
from
6fe0a7e
to
f852475
Compare
|
Created review app at https://npq-registration-review-app-864.london.cloudapps.digital |
Previously there was some duplication between the deployment workflows, each created a separate Docker images and pushed them to Dockerhub. Before the move to Azure we want the Docker images to be pushed to GitHub's container registry (as we'll have fewer sets of credentials to manage). So, instead of implementing it four times I've moved the Docker image steps to their own action and called it from each workflow.
peteryates
force-pushed
the
move-docker-push-to-a-reusable-action
branch
from
fe2b617
to
13c7e6d
Compare
peteryates
requested review from
Lockyy,
leoapost,
javier-npq,
slawosz and
pmanrubia
as code owners
javier-npq
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We'll soon be moving the NPQ app from GOV.UK PaaS to Azure and to stay in line with how other projects/teams are deploying, we'll be switching from Dockerhub to GitHub's container registry. This helps simplify deployment by reducing the number of credentials required.
Changes proposed in this pull request